Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check param, result, type param of function in redefines-builtin-id rule #1023

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

skaji
Copy link
Contributor

@skaji skaji commented Aug 14, 2024

Close #1022

Currently, function related variables (param, result, and type param) are not checked by redefines-builtin-id rule.
It would be nice if revive reports redefinition of the built-in ... errors for function related variables.

Copy link
Collaborator

@denisvmedia denisvmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will give a chance for at least one other review

@skaji
Copy link
Contributor Author

skaji commented Aug 15, 2024

I merged "master" branch to resolve conflict.

@chavacava chavacava merged commit 05c4801 into mgechev:master Aug 15, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: report "redefinition of the built-in" errors for function related variables
3 participants