Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: move lint.Name to name.go file #1084

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alexandear
Copy link
Contributor

The PR moves the lint.Name function from utils.go to name.go. And moves tests for it from the test to lint package.

utils.go is not the best file.

We have recommendations about package names, the same can be applied for file names also:

Avoid meaningless package names like util, common, misc, api, types, and interfaces. See https://go.dev/doc/effective_go#package-names and https://go.dev/blog/package-names for more.

@denisvmedia denisvmedia merged commit 14babf2 into mgechev:master Oct 28, 2024
4 checks passed
@alexandear alexandear deleted the refactor/lint-name branch October 28, 2024 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants