Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: extract getVersion function #1127

Merged
merged 4 commits into from
Nov 18, 2024
Merged

refactor: extract getVersion function #1127

merged 4 commits into from
Nov 18, 2024

Conversation

alexandear
Copy link
Contributor

The PR extracts some functionality to the getVersion() function and adds tests for it.

ccoVeille
ccoVeille approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

ccoVeille
ccoVeille reviewed Nov 16, 2024
View reviewed changes
cli/main.go Outdated Show resolved Hide resolved
cli/main.go Outdated Show resolved Hide resolved
@chavacava chavacava merged commit 93c6bc8 into mgechev:master Nov 18, 2024
5 checks passed
@alexandear alexandear deleted the refactor/extract-get-version-function branch November 18, 2024 13:53
ccoVeille
ccoVeille reviewed Nov 18, 2024
View reviewed changes
cli/main.go Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @ccoVeille @chavacava