refactor: move functions and vars out from rule/utils.go #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
changed the title
alexandear
changed the title
ccoVeille
approved these changes
Nov 19, 2024
|
I checked, these functions are not used outside of the given rules, thus it makes sense to move them close to the rules. Thanks! |
chavacava
pushed a commit
that referenced
this pull request
Nov 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves unexported functions and variable declarations from
utils.goto rule files, where these functions are used. This increases cohesion, readability and rules maintainability.Now, in the
utils.goonly functions that are common for a few rules.