refactor(rule/context-as-argument): replace AST walker by iteration over declarations #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Dec 4, 2024
rule/context_as_argument.go
Outdated
Comment on lines
49
to
50
| // a parameter of type context.Context is still allowed if the current arg type is in the LUT | ||
| _, isCtxStillAllowed = r.allowTypesLUT[typeName] |
There was a problem hiding this comment.
While working on this, LUT terms is cryptic.
Maybe you could rename it
There was a problem hiding this comment.
Yes, is true that makes you think twice this LookUp Table acronym
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies context-as-argument rule by replacing AST walker by an iteration over global declarations