refactor: replace failure Category raw string with constant #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Dec 25, 2024
chavacava
reviewed
Dec 26, 2024
denisvmedia
approved these changes
Jan 6, 2025
ccoVeille
approved these changes
Jan 6, 2025
| // FailureCategoryArgOrder indicates argument order issues. | ||
| FailureCategoryArgOrder FailureCategory = "arg-order" | ||
| // FailureCategoryBadPractice indicates bad practice issues. | ||
| FailureCategoryBadPractice FailureCategory = "bad practice" |
There was a problem hiding this comment.
Maybe a mention this one is not using hyphen while it should bit it was kept like this for compatibility purpose
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds constants for failure categories and replaces raw strings with respective constants.
We can optimize categories in a separate PR. E.g.,
FailureCategoryCodeStyleandFailureCategoryStyleshould be one category.