Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: replace failure Category raw string with constant #1196

Merged

Conversation

alexandear
Copy link
Contributor

The PR adds constants for failure categories and replaces raw strings with respective constants.

We can optimize categories in a separate PR. E.g., FailureCategoryCodeStyle and FailureCategoryStyle should be one category.

// FailureCategoryArgOrder indicates argument order issues.
FailureCategoryArgOrder FailureCategory = "arg-order"
// FailureCategoryBadPractice indicates bad practice issues.
FailureCategoryBadPractice FailureCategory = "bad practice"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a mention this one is not using hyphen while it should bit it was kept like this for compatibility purpose

@chavacava chavacava merged commit 395f790 into mgechev:master Jan 18, 2025
5 checks passed
@alexandear alexandear deleted the refactor/replace-category-str-with-const branch January 18, 2025 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants