Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: cleanup code in rules #1197

Merged
merged 1 commit into from
Dec 31, 2024
Merged

chore: cleanup code in rules #1197

merged 1 commit into from
Dec 31, 2024

Conversation

denisvmedia
Copy link
Collaborator

This PR provides some clean up to make the code homogeneous and address minor issues:

  • pointer vs. non-pointer struct receivers
  • typos/grammar
  • TODO comments on deprecations and potential bugs

ccoVeille
ccoVeille approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@denisvmedia denisvmedia merged commit 4b2c76e into master Dec 31, 2024
5 checks passed
@denisvmedia denisvmedia deleted the rule-code-cleanup branch December 31, 2024 11:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@chavacava chavacava Awaiting requested review from chavacava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisvmedia @ccoVeille