Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: running revive in CI #1205

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: running revive in CI #1205

merged 2 commits into from
Jan 23, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 22, 2025

Without providing the path, revive doesn't analyze all files. The resulting command is:

revive -formatter ndjson -config revive.toml

It looks like there's a bug in morphy2k/revive-action#156.

Now, we have a warning in the codebase:

image

Which I fixed in the second commit.

@chavacava chavacava merged commit d9c61c1 into mgechev:master Jan 23, 2025
10 checks passed
@alexandear alexandear deleted the fix/ci-lint branch January 23, 2025 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants