-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add support for import-alias-naming rule #881
feat: add support for import-alias-naming rule #881
Conversation
@chavacava I'm thinking of making it an array of rules instead of a single rule. This will let users submitting multiple regexes that will be combined as logical AND (so that every rule must match). What do you think? upd: to be clear, the idea is clarity of the configuration. The first regex can be the main, positive, match. Other subsequent regexes may be used to imply negative matches. E.g. to exclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've left some comments.
I personally prefer a single argument. That way there is no need to explain (and understand) how multiple regex are combined (AND or OR?). Yes it can lead to a complex regex but... if you are playing with a regex you know what are you doing :) |
OK, let it be a single regex. |
Closes #880.