New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: remove unused parameter from pick function #932

Merged

chavacava merged 1 commit into mgechev:master from alexandear:rule-refactor-pick-unparam

Nov 6, 2023

Contributor

alexandear commented Nov 4, 2023 •

edited

Loading

This PR refactors internal function: remove the parameter f func(n ast.Node) []ast.Node from pick because it is always nil.

This refactoring was found by the unparam linter:

❯ go run mvdan.cc/unparam@latest ./...
lint/file.go:191:22: (*File).disabledIntervals$3 - filename is unused
lint/file.go:191:95: (*File).disabledIntervals$3 - result 0 ([]github.com/mgechev/revive/lint.DisabledInterval) is always nil
rule/utils.go:98:54: pick - f always receives nil
exit status 1


          refactor: remove unused parameter from pick function

f72ffdb

chavacava merged commit ccae54e into mgechev:master

12 checks passed

Collaborator

chavacava commented Nov 6, 2023

Thank you @alexandear

alexandear deleted the rule-refactor-pick-unparam branch

November 6, 2023 10:04

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet