Improving retry flow #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cursedarcangel
changed the title
golf.mp4The retry button has been moved out of the pause menu, and the intro sequence no longer plays when retrying, it just goes straight to being playable. |
|
This looks great! |
dginovker
reviewed
Jun 12, 2022
src/golf/ui.c
Outdated
| if (_golf_ui_button_name(layout, "pause_menu_retry_button")) { | ||
| _golf_ui_start_fade_out(false, false, 0, true); | ||
| } | ||
| //if (_golf_ui_button_name(layout, "pause_menu_retry_button")) { |
There was a problem hiding this comment.
(Small nitpick) - Don't leave commented out code, it confuses future contributors 😋
There was a problem hiding this comment.
Apparently I forgot this. Thanks for pointing it out.
|
Is there anything in place to prevent accidentally pressing retry and then losing your progress? If not, perhaps a confirmation popup would be a good idea... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes repeating levels to get a better score a much better and more fun experience.