Rename namespace to Sass2Scss #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Aug 23, 2019
1. Avoid include cycles. This isn't necessary for amalgamation but makes things more obvious. 2. Rename sass2scss namespace to Sass2Scss (upstream PR mgreter/sass2scss#43). This is necessary for amalgamation.
This allows this library's source to be amalgamated together with libsass (otherwise we get definition conflicts, e.g. for rtrim).
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Aug 23, 2019
1. Avoid include cycles. This isn't necessary for amalgamation but makes things more obvious. 2. Rename sass2scss namespace to Sass2Scss (upstream PR mgreter/sass2scss#43). This is necessary for amalgamation.
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Aug 24, 2019
1. Avoid include cycles. This isn't necessary for amalgamation but makes things more obvious. 2. Rename sass2scss namespace to Sass2Scss (upstream PR mgreter/sass2scss#43). This is necessary for amalgamation.
paazmaya
approved these changes
Aug 24, 2019
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Aug 27, 2019
1. Avoid include cycles. This isn't necessary for amalgamation but makes things more obvious. 2. Rename sass2scss namespace to Sass2Scss (upstream PR mgreter/sass2scss#43). This is necessary for amalgamation.
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Aug 28, 2019
1. Avoid include cycles. This isn't necessary for amalgamation but makes things more obvious. 2. Rename sass2scss namespace to Sass2Scss (upstream PR mgreter/sass2scss#43). This is necessary for amalgamation.
|
@mgreter Can you merge outstanding PRs? I think we may need a new libsass release before the new parser backport is in-place (due to bugs such as sass/sassc-ruby#149 and sass/libsass#2988) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows this library's source to be amalgamated together with
libsass (otherwise we get definition conflicts, e.g. for rtrim).