Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add Helm Charts section #21

Closed
wants to merge 1 commit into from
Closed

Conversation

clavinjune
Copy link
Contributor

No description provided.

Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@mgumz
Copy link
Owner

mgumz commented Jan 8, 2025

@clavinjune the helm-chart or "a" helm chart would make more sense in the mtr-exporter repository and not in a "random" github-repo somewhere, referred to from README, pointing to an untagged "main" branch.

no sensible OPS person would / should ever install such a combination :)

both the Containerfile as well as Helm chart are kind of an "addon" and thus could both be placed into an "addon" or "support" folder in mtr-exporter repo. A grafana dashboard is another contender to be hosted in such a folder. since ghcr.io can host also helm-charts, one might argue that both the container as well as the chart should originate from the same source.

to your initial helm-template:

so, in its current form i am hesitant to merge this PR.

@mgumz mgumz added the enhancement New feature or request label Jan 8, 2025
@clavinjune clavinjune closed this Jan 9, 2025
@clavinjune
Copy link
Contributor Author

for the moment, I'll close this PR and try to improved the charts in my environment. So as it is said, you'd like the helm-charts to be inside this repository as well?

@mgumz
Copy link
Owner

mgumz commented Jan 9, 2025

you'd like the helm-charts to be inside this repository as well?

Yah, I do not oppose a folder "support" or something like that which contains the Containerfile for people who operate mtr-exporter in a container runtime nor a Helm chart for people operating a zoo of mtr-exporters running on a zoo of container runtimes :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants