Default to STDERR instead of STDOUT #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch restores stack trace logging. It avoids parsing stack trace text, opting for runtime.Callers and runtime.FuncForPC instead. Support for overriding the stack trace by setting KeyMap.CallStack was removed. This only worked in happyDevFormatter, and would have triggered a warning anyway, since it's a reserved key.
|
While I wholeheartedly would like to see this request merged, it is not quite true that a user can do nothing at runtime to redirect the output to STDERR, at least on a lot of Linux/Unix shells: The problem here is rather that this would also redirect output which is intended to go to STDOUT. Hence again, this is a good idea! |
the ci.contextLines is never set (nor was it set in any prior version I could find), but the global contextLines var seems to have the right info. Also: - use the current line marker even when the context is one. This is useful when colors are disabled. - if source context line color is default, the color of the previous line was bleeding over. Need to reset the color on each source line. - found a couple more places where disableColors wasn't being honored
multiple go routines can use a formatter concurrently, and the writes to the formatter's "col" attribute were not synchronized. Instead, create a local col var for each log write.
Fixed logger registration bug
…n docs) to reflect the clone.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logxi is a great almost-drop-in replacement for the Go stdlib log package. However, log defaults to logging on STDERR, whereas logxi defaults to STDOUT. This presents a couple of issues:
This pull request changes the default output to STDERR.