Feature - Drop old tasks with max_count or timedelta #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-wittig
approved these changes
Sep 4, 2024
|
@mher Could you take a look at this one? That seems to be a missing feature in Flower. |
|
This is required. @mher any plans on merging this? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to have the ability to drop tasks in flower: in my case there is a task that runs pretty frequent (for example 2 every mins) and it's important to see last 10 runs and would be better to drop all not important tasks.
This solution is similar to this PR #1188 but I think my approach is better.
You need to add one list in flowerconfig.py and that's all:
limit_tasks_by_type=[ {'type': 'test_task', "max_count": 10, "timedelta": timedelta(minutes=10)}, ]It will keep 10 newest test_task and drop everything else and drop any test_task older that 10 minutes