Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enhancement: Add feature to manually retry failed task #1417

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enhancement: Add feature to manually retry failed task #1417

wants to merge 3 commits into from
+139 −1

Conversation

yashpapa6969
Copy link

Change Log

  • API Update: Introduced the TaskReapply endpoint to reapply tasks with original arguments.
  • Error Handling: Ensures JSON-serializable arguments and robust error logging.
  • Backend Utilities: Added helper functions (parse_args, parse_kwargs, make_json_serializable) for argument parsing and serialization.

@iloveitaly iloveitaly mentioned this pull request Jan 21, 2025
Open
@iloveitaly
Copy link

@mher anything I can do to help get this merged?

sc68cal
sc68cal reviewed Jan 22, 2025
View reviewed changes
flower/utils/tasks.py Outdated Show resolved Hide resolved
@yashpapa6969 yashpapa6969 requested a review from sc68cal January 25, 2025 16:31
sc68cal
sc68cal reviewed Jan 26, 2025
View reviewed changes
flower/utils/tasks.py Outdated Show resolved Hide resolved
@yashpapa6969 yashpapa6969 requested a review from sc68cal January 26, 2025 14:04
sc68cal
sc68cal approved these changes Jan 28, 2025
View reviewed changes
Copy link

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, thank you for this contribution!

@yashpapa6969
Copy link
Author

@sc68cal how can i get this merged?

@sc68cal
Copy link

sc68cal commented Feb 2, 2025

@sc68cal how can i get this merged?

I am not the maintainer, the maintainer needs to approve and merge

marcus-campos
marcus-campos approved these changes Feb 3, 2025
View reviewed changes
Copy link

@marcus-campos marcus-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Ragnarow
Copy link

Ragnarow commented Feb 5, 2025

Thanks for the feature, @mher could we get this merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sc68cal sc68cal sc68cal approved these changes

@marcus-campos marcus-campos marcus-campos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yashpapa6969 @iloveitaly @sc68cal @Ragnarow @marcus-campos