tar: add GNU header (close #13) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. So, this looks to be for creating archives, but does it also successfully read from POSIX tar archives? Does |
|
Both Identify() and Extract() work. archive is succesfully read. |
|
Thanks @M0Rf30 . Will likely merge this in a moment. Do you know if the user has to set FormatGNU manually though? Or can it be detected automatically? (For reading) |
|
Variant is detected automatically from the reader of archive/tar. You only need to specify it on creation. |
|
Okie dokie then. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add POSIX tar archive (GNU) variant support and address #13 request.