fix missing nil arg, neg arg err msgs #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daveliepmann May I request a code review on this? |
|
Sure, I just need a more specific description or link to the error(s) it fixes. There are dozens in that gist :D Also, it's worth checking these against the very-WIP next version at 2.maria.cloud https://2.maria.cloud/gist/fb460019eccd9b49ff5fb3465eea08b7?eval=true |
|
@daveliepmann This PR targets specifically making circles and squares with negative or nil arguments. I will check against WIP2 as well. |
|
Thanks, sorry for the delay |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix missing nil argument error and invalid negative number argument messages in the error outputs. These issues are highlighted in the error doc attached to the wiki here: https://github.com/mhuebert/maria/wiki/Error-Handling