Add support for custom tags

Yaml parser does not allow custom tags by default, but custom tags are needed to use Symfony's shortcut to injecting tagged services https://symfony.com/doc/current/service_container/tags.html#reference-tagged-services
mhujer · Oct 23, 2019 · 064bb14 · 064bb14
1 parent e83c6c5
commit 064bb14
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/SortChecker.php b/src/SortChecker.php
@@ -24,7 +24,7 @@ public function isSorted(
 	): SortCheckResult
 	{
 		try {
-			$data = Yaml::parse(file_get_contents($filename));
+			$data = Yaml::parse(file_get_contents($filename), Yaml::PARSE_CUSTOM_TAGS);
 
 			$errors = $this->areDataSorted($data, $excludedKeys, $excludedSections, null, $depth);
 

diff --git a/tests/SortCheckerTest.php b/tests/SortCheckerTest.php
@@ -16,6 +16,15 @@ public function testSortedFile(): void
 		$this->assertCount(0, $result->getMessages());
 	}
 
+	public function testSortedFileWithCustomTag(): void
+	{
+		$checker = new SortChecker();
+		$result = $checker->isSorted(__DIR__ . '/fixture/ok-tagged.yml', 10);
+
+		$this->assertTrue($result->isOk());
+		$this->assertCount(0, $result->getMessages());
+	}
+
 	public function testInvalidYamlIsInvalid(): void
 	{
 		$checker = new SortChecker();

diff --git a/tests/fixture/ok-tagged.yml b/tests/fixture/ok-tagged.yml
@@ -0,0 +1,8 @@
+services:
+    _instanceof:
+        NonexistentClassInterface:
+            tags: ['nonexistent_tag']
+
+    NonexistentClassImplementation:
+        arguments:
+            - !tagged nonexistent_tag