Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include built-in support for several new emoji shortcodes recently added to gitmoji #316

Closed
TobiasTao opened this issue Jun 1, 2020 · 8 comments
Assignees
Labels
improvement An improvement to existing functionality
Milestone

Comments

@TobiasTao
Copy link

Describe the Bug
emoji wastebasket is not displayed correctly
image

Expected Behaviour
show: 🗑️
Environment

  • Git Graph Extension Version: [1.23.0]
  • Visual Studio Code Version: [1.45.1]
  • Operating System: [Windows 10]
@TobiasTao TobiasTao added the bug Something isn't working label Jun 1, 2020
@mhutchie mhutchie removed the bug Something isn't working label Jun 1, 2020
@mhutchie
Copy link
Owner

mhutchie commented Jun 1, 2020

Hi @TobiasTao,

Git Graph has built-in support for many emoji shortcodes, including all of gitmoji and some other common shortcodes. As there are almost endless shortcodes and different flavours used around the world, I had to decide on a built-in set of the most common (:wastebasket: isn't one of them).

However, when I implemented emoji shortcode replacement, I also created a new Extension Setting Custom Emoji Shortcode Mappings that allows users (like yourself) to define any other emoji's they use (that aren't built-in).

You will be able to use the above mentioned Extension Setting to define a custom mapping for :wastebasket: to your desired emoji.

I'll close this issue as it is not a bug, and this functionality is already provided in Git Graph.

@mhutchie mhutchie closed this as completed Jun 1, 2020
@TobiasTao
Copy link
Author

Thanks you for your reply @mhutchie, but gitmoji already contains :wastebasket:
image
maybe you should update.

@mhutchie mhutchie changed the title Emoji wastebasket is not displayed correctly Include emoji shortcode support for new Gitmoji’s Jun 2, 2020
@mhutchie
Copy link
Owner

mhutchie commented Jun 2, 2020

Hi @TobiasTao,

Thanks for making me aware of that. Since Gitmoji has recently added :wastebasket: (after I added Gitmoji support), I’ll update the built-in list in Git Graph to include it and any other new emojis they’ve recently added.

@mhutchie mhutchie reopened this Jun 2, 2020
@mhutchie mhutchie added the improvement An improvement to existing functionality label Jun 2, 2020
@mhutchie mhutchie added this to the v1.24.0 milestone Jun 2, 2020
mhutchie added a commit that referenced this issue Jun 4, 2020
@mhutchie mhutchie changed the title Include emoji shortcode support for new Gitmoji’s Include built-in support for several new emoji shortcodes recently added to gitmoji Jun 4, 2020
@mhutchie
Copy link
Owner

mhutchie commented Jun 4, 2020

This will be available in v1.24.0.

If you'd like to use it before the next release, you can download v1.24.0-beta.1, and install it following the instructions provided here.

@mhutchie mhutchie closed this as completed Jun 4, 2020
@ADIX7
Copy link

ADIX7 commented Nov 2, 2020

@mhutchie On https://gitmoji.carloscuesta.me/ the documentation icon is now :memo: while in your extension it is :pencil:. Has it been renamed on the site?

@mhutchie
Copy link
Owner

mhutchie commented Nov 2, 2020

Hi @ADIX7,

I've just compared the set of short-codes I last imported from gitmoji into Git Graph, to the latest set of gitmoji. In the last five months, gitmoji have made the following changes:

  • Renamed :pencil: to :memo:
  • Added :passport-control:

I'll apply these changes in the next release of Git Graph, and reply to this thread with a link to a beta release with these changes within the next week.

I've included importing gitmoji into my pre-release steps, so that going forward the set of gitmoji in Git Graph is always kept in sync.

@ADIX7
Copy link

ADIX7 commented Nov 2, 2020

Sounds great, thank you for the fast response!

@mhutchie
Copy link
Owner

mhutchie commented Nov 7, 2020

Hi @ADIX7,

The delivery of the built-in support for the new Gitmoji was tracked by #409. Please see my closure comment on it for a link to the beta release, and instructions for how to install it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement An improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants