Implementation of #112 (support contentMode .scaleAspectFit) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add file ImageViewerTransitionPresentationManager * Update to use new Carthage xcframeworks for SDWebImage * Remove copy frameworks build phase
…nimations) * Explicitly set imageContentMode in the init * Close button to do a normal dismiss which does the transition animation * Minor clean up
jangelsb
commented
Dec 24, 2020
| }) { _ in | ||
| self.dismiss(animated: false, completion: completion) | ||
| } | ||
| self.dismiss(animated: true, completion: nil) |
There was a problem hiding this comment.
This actually allows for the animation transition to run and it looks really nice!
|
Stale pull request message |
|
It's a bummer that such valuable change was closed and not even responded 2 years later. |
Closed
|
@thomasdelgado @jangelsb i’m sorry if i missed this pr. I’m reopening this. Thank you |
|
this pr is looking good, created #125 this pr instead for resolving some git conflicts and some minor modifications. thank you so much. |
|
Sweet! I am glad it got merged in and is hopefully helpful for others 😊 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
First two commits were me getting the code to compile locally on an M1 MacBookPro
Add the ability to pass in a contentMode in the ImageViewerOptions
Demo of customizing the contentMode to
.scaleAspectFitand new close animation:https://user-images.githubusercontent.com/11953370/103055533-583c1e80-454f-11eb-93fb-cebc596ec022.mp4