Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MMCore: Remove deprecated functions #396

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

marktsuchida
Copy link
Member

@marktsuchida marktsuchida commented Oct 31, 2023

Closes #284.

This increments the MMCore API version to 11.0.0, since it removes existing functionality.
All the removed functions have been deprecated for at least 1 year (some for 9 years).

Internal code and build settings related to the removed functions have also been removed.

Removed public functions:

MMCORE_DEPRECATED(static void addSearchPath(const char *path));
MMCORE_DEPRECATED(static std::vector<std::string> getDeviceLibraries() throw (CMMError));

MMCORE_DEPRECATED(void waitForImageSynchro() throw (CMMError));
MMCORE_DEPRECATED(void assignImageSynchro(const char* deviceLabel) throw (CMMError));
MMCORE_DEPRECATED(void removeImageSynchro(const char* deviceLabel) throw (CMMError));
MMCORE_DEPRECATED(void removeImageSynchroAll());

MMCORE_DEPRECATED(void definePropertyBlock(const char* blockName, const char* propertyName,
MMCORE_DEPRECATED(std::vector<std::string> getAvailablePropertyBlocks() const);
MMCORE_DEPRECATED(PropertyBlock getPropertyBlockData(const char* blockName));
MMCORE_DEPRECATED(PropertyBlock getStateLabelData(const char* stateDeviceLabel,
MMCORE_DEPRECATED(PropertyBlock getData(const char* stateDeviceLabel));

MMCORE_DEPRECATED(std::string getUserId() const);
MMCORE_DEPRECATED(std::string getHostName() const);
MMCORE_DEPRECATED(std::vector<std::string> getMACAddresses(void));

Removed public types:

class PropertyBlock;
struct PropertyPair;

Before merging, I will:

  • Ensure Windows build works (macOS already tested)
  • Ensure device adapter search paths still work correctly (since some code simplification was done)

This also removes the config file command ImageSynchro, which is now an
error.
This also removes the config file command Equipment, which is now an
error.
This also simplifies some OS-specific dependencies.
For removal of deprecated CMMCore functions and config file commands.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated functions from MMCore
1 participant