Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: remove Fluent Assertions from unit tests #33

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

SebastienDegodez
Copy link
Member

@SebastienDegodez SebastienDegodez commented Jan 18, 2025

Pull Request

Proposed Changes

  • Updated all test methods to use Xunit's Assert class
  • Removed package dependency

resolves #32

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run dotnet test and ensure you have test coverage for the lines you are introducing
  • run dotnet husky run and fix any issues that you have introduced

Reviewer

  • Label as either feature, fix, documentation, enhancement, maintenance or breaking

- Updated all test methods to use Xunit's Assert class
- Removed package dependency
resolves #32

Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
@SebastienDegodez SebastienDegodez marked this pull request as ready for review January 18, 2025 16:12
@lbroudoux lbroudoux added dependencies Pull requests that update a dependency file kind/task labels Jan 23, 2025
@lbroudoux lbroudoux added this to the 0.2.0 milestone Jan 23, 2025
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! Thanks @SebastienDegodez

@lbroudoux lbroudoux merged commit 0295976 into main Jan 23, 2025
13 checks passed
@lbroudoux lbroudoux deleted the feature/remove-fluentassertion branch January 23, 2025 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file kind/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin or remove fluentassertions
2 participants