fix: ensure network are started asynchronously in InitializeAsync #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienDegodez
force-pushed
the
fix/unit-test-oauth
branch
from
3043b2b to
7a9f122
Compare
Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
SebastienDegodez
force-pushed
the
fix/unit-test-oauth
branch
from
7a9f122 to
24ffab0
Compare
This ensure completion mechanism works and result is received after timeout Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
SebastienDegodez
force-pushed
the
fix/unit-test-oauth
branch
from
8c8d8ea to
dec9806
Compare
|
@lbroudoux The stopwatch was added to measure the elapsed time during the test execution. This ensures that the test waits for the specified timeout before completing. Here is a simplified version of the test with an explanation. We had a test failure on the I compare with JAVA implementation, and I don't understand. The Timeout is 70.001 and the assertion use 7.000. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
fix: ensure network creation in Initialize method to stabilize tests
Proposed Changes
This fix addresses random test failures encountered when a network is used, caused by a missing network creation in the Initialize method of the
IAsyncLifetimeinterface. Tests should now execute consistently without failures due to missing network.Readiness Checklist
Author/Contributor
dotnet testand ensure you have test coverage for the lines you are introducing.dotnet husky runand fix any issues that you have introduced.Reviewer
feature,fix,documentation,enhancement,maintenance, orbreaking.