Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Arrays type and rels should not contain duplicate items #159

Closed
gRegorLove opened this issue Mar 21, 2018 · 0 comments
Closed

Arrays type and rels should not contain duplicate items #159

gRegorLove opened this issue Mar 21, 2018 · 0 comments
Milestone

Comments

@gRegorLove
Copy link
Member

<div class="h-entry h-cite h-entry">
  <a href="#" rel="me bookmark me"></a>
</div>

Currently parses:

{
    "items": [
        {
            "type": [
                "h-cite",
                "h-entry",
                "h-entry"
            ],
            "properties": {
                "name": [
                    ""
                ],
                "url": [
                    "#"
                ]
            }
        }
    ],
    "rels": {
        "me": [
            "#",
            "#"
        ],
        "bookmark": [
            "#"
        ]
    },
    "rel-urls": {
        "#": {
            "rels": [
                "me",
                "bookmark",
                "me"
            ]
        }
    },
    "debug": {
        "package": "https://packagist.org/packages/mf2/mf2",
        "version": "v0.4.1",
        "note": [
            "This output was generated from the php-mf2 library available at https://github.com/indieweb/php-mf2",
            "Please file any issues with the parser at https://github.com/indieweb/php-mf2/issues"
        ]
    }
}

Expected output:

{
    "items": [
        {
            "type": [
                "h-cite",
                "h-entry"
            ],
            "properties": {
                "name": [
                    ""
                ],
                "url": [
                    "#"
                ]
            }
        }
    ],
    "rels": {
        "bookmark": [
            "#"
        ]
        "me": [
            "#"
        ]
    },
    "rel-urls": {
        "#": {
            "rels": [
                "bookmark",
                "me"
            ]
        }
    }
}

Per spec update: microformats/microformats2-parsing#30

Zegnat added a commit to Zegnat/php-mf2 that referenced this issue Mar 22, 2018
* Parse the rel attribute in accordance with the WHATWG spec:
  https://infra.spec.whatwg.org/#split-on-ascii-whitespace
* Only list unique rel values in the rel-urls output, fixes microformats#159:
  microformats/microformats2-parsing#30
* Sort the unique rel values alphabetically:
  microformats/microformats2-parsing#29
* Correctly merge attribute values into the resulting object.
Zegnat added a commit to Zegnat/php-mf2 that referenced this issue Mar 24, 2018
* Parse the rel attribute in accordance with the WHATWG spec:
  https://infra.spec.whatwg.org/#split-on-ascii-whitespace
* Only list unique rel values in the rel-urls output, fixes microformats#159:
  microformats/microformats2-parsing#30
* Sort the unique rel values alphabetically:
  microformats/microformats2-parsing#29
* Correctly merge attribute values into the resulting object.
@aaronpk aaronpk added this to the 0.4.2 milestone Mar 25, 2018
Zegnat added a commit to Zegnat/php-mf2 that referenced this issue Mar 25, 2018
aaronpk added a commit that referenced this issue Mar 26, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants