-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
h-event time test should not normalise timezone -v2 #29
Comments
Yes your right. My parser is been a bit too clever and normalising dates. I am using ISO 8601 date "profiles" which are like a set of sub rules that restrict the ISO 8601. The default profile drops colon from timezone. The tests needs changing and I need to add a flag for "date normalisation" which is switch off by default. Unless of cause we add date normalisation to parsing rules : ) I will do this in next round of updates |
Normalizing is a proposal, I have it implemented and commented out in |
The tests now do NOT normalising dates as per current parsing rules. Leave this issue open while normalising dates is discussed. |
@tantek recently resolved http://microformats.org/wiki/microformats2-parsing-issues#parsing_a_dt-_property. It seemed to be mainly focused on normalizing dates with regards to space vs "T" as a separator and removal of implying 00 seconds. However, the vcp page is also now pretty clear that a resulting dt value should not have colons in the timezone. |
h-event/dates example is normalizing to add the colons still. |
Parsing for Edit: realized the OP is about a different test; my comment here was only about previous comment for |
Nudging this because this test is the only v2 test that's failing for the Rust library. Should we opt to keep (current behavior expected in the Rust library), preserve as authored, or drop the colon in offsets? (Originally published at: https://jacky.wtf/2022/6/kduV) |
Specification updated (microformats/microformats2-parsing#56) to normalize by removing colon in timezone offset, so these tests can be updated accordingly. Note this only applies to VCP for now; see separate issue microformats/microformats2-parsing#12 |
I reviewed the master branch and confirmed that 17d31db normalized the test outputs, so no additional test updates are needed to resolve this issue. |
in
microformats-v2/h-event/time.html
the output reads
with the colon removed from the first timezone. There is an issue discussing normalisation, but for now http://microformats.org/wiki/value-class-pattern#Date_and_time_parsing seems to indicate the colon should be preserved.
The text was updated successfully, but these errors were encountered: