Use direct equals call instead of Objects.equals wrapper #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We known that `name` and `tags` are non-null values. (E.g. hashCode doesn't have `null` checks). When we know that value is non-null - we can call `equals` directly - it will be a bit faster Signed-off-by: Andrey Turbanov <turbanoff@gmail.com>
shakuzen
changed the title
shakuzen
added
enhancement
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
shakuzen
approved these changes
Jan 30, 2025
Signed-off-by: Andrey Turbanov <turbanoff@gmail.com>
|
Thanks for the pull request. This will be included in the upcoming 1.15.0-M2 release. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We known that
nameandtagsare non-null values. (E.g. hashCode doesn't havenullchecks). When we know that value is non-null - we can callequalsdirectly - it will be a bit faster