Handle programatically added log4j2 LoggerConfig #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The goal of this is to be able to bind to a newly added `LoggerConfig` even if the `Configuration` is the same * This means we always need to check if the filter was already added to avoid adding it twice * We need to keep track of if anything was changed to avoid an endless loop when we call `updateLoggers()` Signed-off-by: Patrik Ivarsson <patrik.ivarsson@avanza.se>
shakuzen
approved these changes
Feb 12, 2025
...meter-core/src/test/java/io/micrometer/core/instrument/binder/logging/Log4j2MetricsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrik Ivarsson <patrik.ivarsson@avanza.se>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The needed change for being able to bind to programmatically added loggers is simply to remove
listener.getOldValue() != listener.getNewValue().However, when we do that it leads to three things:
MetricsFilteris already added to avoid adding it again on configuration reloadupdateLoggers()to avoid an endless loop (as the listener will be triggered again when callingupdateLoggers()Configurationto the conditional beforeremoveMetricsFilterto avoid removing all filters when we reload with the sameConfigurationinstanceI did this by returning whether a
MetricsFilterwas added or not fromregisterMetricsFilter(). I tried out some different ways of doing this, but I ended up refactoring it a bit and I think it ended up quite readable.I have also included a test that adds a logger programmatically (which would fail without these changes). It also verifies that
updateLoggers()is called once with the newMetricsFilterconfigured, as expected.Resolves #5901