Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Linux build improvements - clang8, no custom libcxx #2500

Merged

Conversation

madratman
Copy link
Contributor

@madratman madratman commented Apr 1, 2020

  • Tested with UE4.24, Ubuntu 18 (might have to enforce 4.24, right now we support >=4.22)
    • or add option for clang-7 for UE 4.22
  • install clang-, libc++-8-dev, libc++abi-8-dev in setup.sh
  • remove all the clang5.0 and custom libcxx download and building
  • in commonsetup.cmake, throwing in a -stdlib=libc++ and removing all the unreal specific flags seems to the job

@madratman madratman force-pushed the PR/linux_clang_8_no_custom_libcxx branch 5 times, most recently from 1efc169 to e19b6e9 Compare April 1, 2020 03:43
setup.sh Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
@madratman madratman force-pushed the PR/linux_clang_8_no_custom_libcxx branch 2 times, most recently from ca15a17 to 9d46989 Compare April 1, 2020 03:54
@rajat2004
Copy link
Contributor

PRs working properly for me, manually removed the llvm-build directory, but no problems
Some new warnings are there, which is expected when upgrading to a new compiler
Travis build of the current PR - https://travis-ci.com/github/rajat2004/AirSim/builds/157408468

@rajat2004
Copy link
Contributor

@madratman I've opened madratman#1 against this branch on your fork, which updates the compiler for OSX
Travis build - https://travis-ci.com/github/rajat2004/AirSim/builds/157476649

@rajat2004
Copy link
Contributor

Also, what should be done with the Unity compilation? That is still using clang-5

@madratman madratman force-pushed the PR/linux_clang_8_no_custom_libcxx branch from 2f47ac5 to 4dba8c1 Compare April 1, 2020 16:52
@madratman madratman merged commit 6f2d0f7 into microsoft:master Apr 1, 2020
@madratman
Copy link
Contributor Author

travis is working for upstream airsim as well - https://travis-ci.org/github/microsoft/AirSim/builds/669789574 / https://travis-ci.org/github/microsoft/AirSim/pull_requests
but for some reason, not showing up on gh PR page

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants