Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduced warning level in Unity build #2672

Merged
merged 2 commits into from
May 8, 2020
Merged

Conversation

saihv
Copy link
Contributor

@saihv saihv commented May 7, 2020

Attempts to address #2478 by removing -Weverything and using -Wall -Wextra to drive the Unity build process.

CC @rajat2004

@rajat2004
Copy link
Contributor

@saihv I've opened saihv#1 against your branch which fixes the warnings for me atleast
Though I still think that the root cause described in the issue might be applicable, which would be great to have a review of by someone who's more experienced in Cmake than me

* [Unity] Reduce build warnings

Change -Weverything to -Wextra

* [Travis] Simplify Unity build command

* [Unity] Fix missing override warnings
@saihv saihv merged commit 961456c into microsoft:master May 8, 2020
rajat2004 added a commit to rajat2004/AirSim that referenced this pull request Jul 18, 2020
* Reduced warning level in Unity build

* Pr/2672 (#1)

* [Unity] Reduce build warnings

Change -Weverything to -Wextra

* [Travis] Simplify Unity build command

* [Unity] Fix missing override warnings

Co-authored-by: Rajat Singhal <rajatsinghal564@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants