-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix DepthPlanar capture #3907
Fix DepthPlanar capture #3907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saihv, which version of the unreal engine are you using to save the .uasset in this PR? In UE 4.25.4, I'm getting load failures when launching the Blocks environment:
Message
Default Property warnings and errors:
Error: CDO Constructor (CarPawn): Failed to find /AirSim/Blueprints/BP_PIPCamera.BP_PIPCamera_C
Error: CDO Constructor (ComputerVisionPawn): Failed to find /AirSim/Blueprints/BP_PIPCamera.BP_PIPCamera_C
Error: CDO Constructor (SimModeBase): Failed to find /AirSim/Blueprints/BP_PIPCamera.BP_PIPCamera_C
Error: CDO Constructor (SimModeBase): Failed to find /AirSim/Blueprints/BP_PIPCamera.BP_PIPCamera_C
The BP_PIPCamera.uasset file doesn't appear in the content browser, and launching the environment results in an unhandled exception and crash. Would you be able to re-save your changes in UE 4.25 to ensure compatibility with the currently supported version of Unreal?
I can't see the output but shouldn't this 4.25 incompatibility have been caught by the Azure Pipelines? It uses 4.25.1 based on the ci.yaml file |
@zimmy87 I've replaced the asset with a 4.25-saved one, could you try now? |
@saihv seems like you pushed |
Whoops, fixed! |
Thanks for the submission @saihv! Tested locally and it works for me. |
Fixes: #3776
Fixes: #3716
Fixes: #3648
About
Fixes an issue with PIPCamera where it was missing the reference to the Depth Planar material. Earlier, requesting a DepthPlanar issue would return a grayscale/RGB image instead of depth.
How Has This Been Tested?