-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ability to spawn/destroy lights and control light parameters #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajat2004
reviewed
Aug 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making almost the same changes in spawnObject
in #3940 😆 (apart from the is_blueprint
)
The API needs to be added in RpcLibClientBase and Unity files also
rajat2004
reviewed
Aug 29, 2021
zimmy87
suggested changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some style comments
address feedback from rajat2004
response to feedback from rajat2004
recreate PointLightBP.uasset & SpotLightBP.uasset so they're compatible with UE 4.25
respond to feedback from zimmy87
adding stub for new setLightIntensity API
zimmy87
approved these changes
Nov 11, 2021
😂 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR adds the ability to spawn blueprints in the world along with static mesh actors. Additionally, it introduces a couple of sample blueprint wrappers for a Point light and a Spot light, and allows spawning or destroying them - which could be useful for dynamic changes in indoor environments. This method of control wraps the lights in a blueprint (see
Content/Blueprints/Lights
) that allows for spawning as well as easier, extensible control.The main thing to note is that to be able to use this API, the light being targeted should be a blueprint.
A new API function
simSetLightIntensity()
allows for changing the brightness of the lights. Example usage of the entire pipeline can be seen inPythonClient/environment/light_control.py
How Has This Been Tested?
Drag
Blueprints/Lights/PointLightBP.uasset
into any world (e.g. Blocks), and then runPythonClient/environment/light_control.py
Video:
2021-08-27.18-58-19-1.mp4