-
Notifications
You must be signed in to change notification settings - Fork 204
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better sampling override behavior (#4014)
- Loading branch information
Showing
15 changed files
with
684 additions
and
151 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 105 additions & 0 deletions
105
...a/com/microsoft/applicationinsights/agent/internal/sampling/AiFixedPercentageSampler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.microsoft.applicationinsights.agent.internal.sampling; | ||
|
|
||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.AiSemanticAttributes; | ||
| import io.opentelemetry.api.common.Attributes; | ||
| import io.opentelemetry.api.trace.Span; | ||
| import io.opentelemetry.api.trace.SpanContext; | ||
| import io.opentelemetry.api.trace.SpanKind; | ||
| import io.opentelemetry.context.Context; | ||
| import io.opentelemetry.sdk.trace.ReadableSpan; | ||
| import io.opentelemetry.sdk.trace.data.LinkData; | ||
| import io.opentelemetry.sdk.trace.samplers.Sampler; | ||
| import io.opentelemetry.sdk.trace.samplers.SamplingResult; | ||
| import java.util.List; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| public class AiFixedPercentageSampler implements Sampler { | ||
|
|
||
| private final double percentage; | ||
|
|
||
| public static AiFixedPercentageSampler create(double percentage) { | ||
| return new AiFixedPercentageSampler(percentage); | ||
| } | ||
|
|
||
| private AiFixedPercentageSampler(double percentage) { | ||
| this.percentage = percentage; | ||
| } | ||
|
|
||
| @Override | ||
| public SamplingResult shouldSample( | ||
| Context parentContext, | ||
| String traceId, | ||
| String name, | ||
| SpanKind spanKind, | ||
| Attributes attributes, | ||
| List<LinkData> parentLinks) { | ||
|
|
||
| Span parentSpan = Span.fromContext(parentContext); | ||
| SpanContext parentSpanContext = parentSpan.getSpanContext(); | ||
| Double parentSpanSampleRate = null; | ||
| if (parentSpan instanceof ReadableSpan) { | ||
| parentSpanSampleRate = | ||
| ((ReadableSpan) parentSpan).getAttribute(AiSemanticAttributes.SAMPLE_RATE); | ||
| } | ||
|
|
||
| return internalShouldSample(parentSpanContext, parentSpanSampleRate, traceId); | ||
| } | ||
|
|
||
| public SamplingResult shouldSampleLog(SpanContext spanContext, @Nullable Double spanSampleRate) { | ||
| return internalShouldSample(spanContext, spanSampleRate, spanContext.getTraceId()); | ||
| } | ||
|
|
||
| private SamplingResult internalShouldSample( | ||
| SpanContext parentSpanContext, @Nullable Double parentSpanSampleRate, String traceId) { | ||
|
|
||
| SamplingResult samplingResult = | ||
| useLocalParentDecisionIfPossible(parentSpanContext, parentSpanSampleRate); | ||
| if (samplingResult != null) { | ||
| return samplingResult; | ||
| } | ||
|
|
||
| return SamplerUtil.shouldSample(traceId, percentage); | ||
| } | ||
|
|
||
| @Nullable | ||
| private SamplingResult useLocalParentDecisionIfPossible( | ||
| SpanContext parentSpanContext, @Nullable Double parentSpanSampleRate) { | ||
|
|
||
| // remote parent-based sampling messes up item counts since item count is not propagated in | ||
| // tracestate (yet), but local parent-based sampling doesn't have this issue since we are | ||
| // propagating item count locally | ||
|
|
||
| if (!parentSpanContext.isValid() || parentSpanContext.isRemote()) { | ||
| return null; | ||
| } | ||
|
|
||
| if (!parentSpanContext.isSampled()) { | ||
| if (percentage < 100) { | ||
| // only 100% sampling override will override an unsampled parent!! | ||
| return SamplingResult.drop(); | ||
| } else { | ||
| // falls back in this case to percentage | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| if (parentSpanSampleRate == null) { | ||
| return null; | ||
| } | ||
|
|
||
| if (percentage < parentSpanSampleRate || percentage == 100) { | ||
| // falls back in this case to percentage | ||
| return null; | ||
| } | ||
| // don't sample more dependencies than parent in this case | ||
| return SamplerUtil.createSamplingResultWithSampleRateAndItemCount(parentSpanSampleRate); | ||
| } | ||
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "FixedPercentageSampler"; | ||
| } | ||
| } |
Oops, something went wrong.