Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added fallback method select container by name #347

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

TTmaister
Copy link
Contributor

Proposal #344

Fallback method if container id has not provided.

Read ContainerName environment variable and find first container by name

@TTmaister
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@xiaomi7732 xiaomi7732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It largely looks good to me. There's only one small piece about null handling, do you mind taking a look? (y)

@xiaomi7732 xiaomi7732 added this to the 6.1.1 milestone Mar 29, 2023
@xiaomi7732 xiaomi7732 linked an issue Mar 29, 2023 that may be closed by this pull request
@xiaomi7732 xiaomi7732 merged commit 1b28860 into microsoft:develop Mar 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigation: Using a label to locate the current container
2 participants