#1740 fix Luminosity on dialog link color #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
|
You might want to double check what this looks like on HC. We use a darker dialog. |
corinagum
force-pushed
the
corinagum/1740
branch
from
275f350 to
ce30cbd
Compare
|
@tonyanziano I'm reverting the change to high-contrast since you're right and the change doesn't pass. Old color passes no problems. |
tonyanziano
approved these changes
Aug 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1740
Updated the link color in
botCreationDialogandbotSettingsEditorto be#3062D6, which passes Luminosity contrast ratio guidelines when on#f4f4f4background. The new appearance is:Just as quick proof that this doesn't affect other links, here is a list of all instances of
--link-color, which only occur in dialogs (where this change needs to be affected).