Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[#1833] Added landmarks for improved keyboard navigation. #1864

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[#1833] Added landmarks for improved keyboard navigation. #1864

merged 1 commit into from
Sep 11, 2019

Conversation

tonyanziano
Copy link
Contributor

#1833

===

Added ARIA landmarks for easier keyboard navigation.

Here's a visual representation:

image

If the tabs are split, the two groups will read: "primary editor region" & "secondary editor region"

corinagum
corinagum approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! looks good

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 65.826% when pulling c40ea19 on toanzian/acc-#1833 into c7a8a91 on master.

@tonyanziano tonyanziano merged commit 7ef388a into master Sep 11, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1833 branch September 11, 2019 23:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum