[#1771] DefaultButton a11y styling fixes #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
cwhitten
approved these changes
Oct 15, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1771
This PR fixes the styling for the
<DefaultButton>(Cancel button on dialogs) component, which previously was not high enough contrast. I got these specs from @DesignPolice, which are borrowing a bit from v.next design (Fluent) for styling / simplicity of implementation. Using colors available inneutral.csswas complicated and started a chain reaction in color-swaps, so this is the simple alternative we went with.Please see below for a gif overview of what the default button now looks like in all three themes. No testing added.