Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#1907] Add / sort service menus now show under trigger buttons. #1993

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

tonyanziano
Copy link
Contributor

#1907

===

The add and sort service pane buttons spawn a context menu. The old behavior spawned the menu at the cursors' current position (Electron's default). Now, the context menu is spawned directly under the triggering button.

Before:

image

sort-service-before

After:
add-service-after
sort-service-after

@coveralls
Copy link

coveralls commented Nov 19, 2019

Coverage Status

Coverage increased (+0.07%) to 68.529% when pulling 9992506 on toanzian/acc-#1907 into 99c46c8 on master.

corinagum
corinagum previously approved these changes Nov 19, 2019
@tonyanziano tonyanziano merged commit dbc1b91 into master Nov 20, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1907 branch November 20, 2019 19:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants