Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Moved shared store code to app/shared. #2060

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Moved shared store code to app/shared. #2060

merged 3 commits into from
Jan 30, 2020

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Jan 24, 2020

Fixes #2038

===

Basically moved all reducer and action code to packages/app/shared/state.

So 99% of this PR is changing imports from:

import { closeBot } from '../../state/actions/botActions'
import { bot } from '../../state/reducers/bot';

to

import { bot, closeBot } from '@bfemulator/app-shared';

350 files... whoops 😅

@coveralls
Copy link

coveralls commented Jan 24, 2020

Coverage Status

Coverage decreased (-1.6%) to 67.983% when pulling 64d0eb7 on toanzian/state into 3b1c824 on master.

@tonyanziano
Copy link
Contributor Author

I didn't really add any new code, I just deleted a bunch of duplicate tested code and I believe that's why the coverage dropped:

Before:

2633 of 4488 branches covered (58.67%)

After:

2428 of 4267 branches covered (56.9%)

srinaath
srinaath previously approved these changes Jan 30, 2020
@srinaath
Copy link
Contributor

This PR is awesome @tonyanziano . So much redundancy removed

@tonyanziano tonyanziano merged commit 4e00746 into master Jan 30, 2020
@tonyanziano tonyanziano deleted the toanzian/state branch January 30, 2020 20:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Move state store code to /app/shared
3 participants