Skip to content

Commit

Permalink
Merge branch 'main' of github.com:microsoft/CCF into multi_threaded_s…
Browse files Browse the repository at this point in the history
…np_take2
  • Loading branch information
eddyashton committed Feb 20, 2025
2 parents 0e93076 + 4d3b6ec commit f9d1b38
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/long-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -324,5 +324,5 @@ jobs:
# Unit tests
./tests.sh --output-on-failure -L unit -j$(nproc --all)
# All e2e tests, which are now supported on Mariner.
./tests.sh --timeout 1600 --output-on-failure -LE "benchmark|lts_compatibility"
./tests.sh --timeout 1600 --output-on-failure -LE "benchmark"
shell: bash
2 changes: 1 addition & 1 deletion cmake/cpack_settings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ set(CPACK_RPM_PACKAGE_REQUIRES "${CCF_RPM_DEPENDENCIES}")
# Default is formed as `name + version + release + architecture` joined via `-`.
# To keep consistent release naming, we want - package name as `name + version
# + architecture` - output format via underscore:
# `name_version_release_architecture.rpm`
# `name_version_architecture.rpm`

# CPACK_RPM_PACKAGE_ARCHITECTURE is empty for some reason, however it should be
# set to `uname -m` output, see
Expand Down
6 changes: 3 additions & 3 deletions include/ccf/pal/attestation.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ namespace ccf::pal
auto quote =
*reinterpret_cast<const snp::Attestation*>(quote_info.quote.data());

if (quote.version != snp::attestation_version)
if (quote.version < snp::minimum_attestation_version)
{
throw std::logic_error(fmt::format(
"SEV-SNP: Attestation version is {} not expected {}",
"SEV-SNP: Attestation version is {} not >= expected minimum {}",
quote.version,
snp::attestation_version));
snp::minimum_attestation_version));
}

if (quote.flags.signing_key != snp::attestation_flags_signing_key_vcek)
Expand Down
2 changes: 1 addition & 1 deletion include/ccf/pal/attestation_sev_snp.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ QPHfbkH0CyPfhl1jWhJFZasCAwEAAQ==
#pragma pack(push, 1)
// Table 21

static constexpr uint32_t attestation_version = 2;
static constexpr uint32_t minimum_attestation_version = 2;
static constexpr uint32_t attestation_policy_abi_major = 1;

struct Attestation
Expand Down

0 comments on commit f9d1b38

Please # to comment.