[inf] Add config var to enable keeping module on host #6846
+53
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using keep_module_on_host config var will let us control if the loaded checkpoints to model parameters will be moved to the device or stay on host
oelayan7
requested review from
awan-10,
tjruwase,
loadams and
tohtana
as code owners
tjruwase
reviewed
Dec 11, 2024
deepspeed/module_inject/auto_tp.py
Outdated
| @@ -17,9 +17,11 @@ | |||
| from deepspeed.module_inject.tp_shard import get_shard_size, get_shard_size_list | |||
|
|
|||
|
|
|||
| def move(tensor, device): | |||
| def move(tensor, device, keep_module_on_host=False): | |||
There was a problem hiding this comment.
Won't it be simpler to modify callers to pass device='cpu' when keep_module_on_host=True?
|
@tjruwase Can you please rereview and retrigger the CI? |
tjruwase
reviewed
Jan 6, 2025
| @@ -554,6 +554,7 @@ def test(self, model_w_task, injection_policy, query, inf_kwargs, assert_fn, dty | |||
|
|
|||
|
|
|||
| @pytest.mark.seq_inference | |||
| @pytest.mark.parametrize('keep_module_on_host', [True, False]) | |||
There was a problem hiding this comment.
Is it useful to validate that tensors are on cpu when keep_module_on_host=True?
There was a problem hiding this comment.
@tjruwase
You're right.
A check was added.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using keep_module_on_host config var will let us control if the loaded checkpoints to model parameters will be moved to the device or stay on host