Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

detour_skip_jmp for x64 doesn't support rex.w prefix #293

Open
ww898 opened this issue Jul 18, 2023 · 0 comments
Open

detour_skip_jmp for x64 doesn't support rex.w prefix #293

ww898 opened this issue Jul 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ww898
Copy link

ww898 commented Jul 18, 2023

Hi, I found that DetourCodeFromPointer doesn't work propely for OutputDebugStringA on x64 platform because detour_skip_jmp doesn't handle rex.w (0x48) prefix before jmp [+imm32] (0xFF, 0x25, 0xXX, 0xXX, 0xXX, 0xXX). Could you please fix it?

Detours/src/detours.cpp

Line 380 in 734ac64

if (pbCode[0] == 0xff && pbCode[1] == 0x25) { // jmp [+imm32]

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ww898