Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

detour_skip_jmp for arm64 doesn't support unconditional branch #295

Open
valco1994 opened this issue Jul 21, 2023 · 1 comment
Open

detour_skip_jmp for arm64 doesn't support unconditional branch #295

valco1994 opened this issue Jul 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@valco1994
Copy link

valco1994 commented Jul 21, 2023 •
edited
Loading

Hello! I found that there is almost the same issue as #293 with DetourCodeFromPointer on arm64. It doesn't work properly for OutputDebugStringA, because detour_skip_jmp doesn't support unconditional jump B <label>. As a result, when you try to hook OutputDebugStringA you are actually hooking kernel32.dll!OutputDebugStringAStub instead of the KernelBase.dll!OutputDebugStringA.

Detours/src/detours.cpp

Line 1049 in 734ac64

inline PBYTE detour_skip_jmp(PBYTE pbCode, PVOID *ppGlobals)

@valco1994 valco1994 added the bug Something isn't working label Jul 21, 2023
@valco1994
Copy link
Author

It's necessary to consider #296 when you will be fixing this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valco1994