Fix HelperLaneTest (release branch version) #5769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-opt-disable sink` to HelperLaneTest shader compilation to prevent sinking of `ddx_fine`/`ddy_fine` intrinsics into flow control. Separate issue has been filed to track down the root of the problem: microsoft#5744: Intrinsics ddx_fine/ddy_fine should not be allowed to sink into flow control
hekota
changed the title
llvm-beanz
approved these changes
Sep 21, 2023
python3kgae
approved these changes
Sep 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-opt-disable sinkto HelperLaneTest shader compilation to prevent sinking ofddx_fine/ddy_fineintrinsics into flow control.Separate issue has been filed to track down the root of the problem: #5744: Intrinsics ddx_fine/ddy_fine should not be allowed to sink into flow control