Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use const string to reference feature name #294

Merged
merged 3 commits into from
Nov 10, 2023
Merged

use const string to reference feature name #294

merged 3 commits into from
Nov 10, 2023

Conversation

zhiyuanliang-ms
Copy link
Contributor

Issue #291

jimmyca15
jimmyca15 reviewed Nov 8, 2023
View reviewed changes
tests/Tests.FeatureManagement/FeatureFlags.cs Outdated
//
namespace Tests.FeatureManagement
{
static class FeatureFlags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change Features to FeatureFlags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it back to Features. In README, we use "FeatureFlag".

@zhiyuanliang-ms zhiyuanliang-ms merged commit 9fcc4b1 into main Nov 10, 2023
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/change-feature-flag-reference branch November 10, 2023 04:59
@zhiyuanliang-ms zhiyuanliang-ms mentioned this pull request Mar 19, 2024
Merged
@zhiyuanliang-ms zhiyuanliang-ms changed the title use const string to referece feature name use const string to reference feature name Mar 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jimmyca15 jimmyca15 jimmyca15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyuanliang-ms @jimmyca15