Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typo in warning message in time window filter #401

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix typo in warning message in time window filter #401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b04f63
fix typo in warning message in time window filter
zhiyuanliang-ms Mar 14, 2024
fa66958
resolve conflict
zhiyuanliang-ms Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.FeatureManagement/FeatureFilters/TimeWindowFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)

if (!settings.Start.HasValue && !settings.End.HasValue)
{
_logger?.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must have have specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");
_logger?.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");

return Task.FromResult(false);
}
Expand Down