This repository was archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Fixing bugs when running container models on multiple GPUs #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix inference for container models
melanibe
approved these changes
Apr 23, 2021
javier-alvarez
approved these changes
Apr 23, 2021
# Lightning does not cope with having two calls to .fit or .test in the same script. As a workaround for | ||
# now, restrict number of GPUs to 1, meaning that it will not start DDP. | ||
self.container.max_num_gpus = 1 | ||
trainer = create_lightning_trainer(self.container, num_nodes=1)[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trainer, _ = create... looks more readable than [0] but minor stuff
Shruthi42
approved these changes
Apr 23, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs:
use_gpu
flag for container models was not picked up correctly, always running without GPUtest_step
method, PL would fail when running on >1 GPUAdds an extra test to run the
HelloContainer
model in AzureML