This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix incomplete test data module setup in Lightning inference #553
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the inference code-path for Lightning containers, we call
LightningDataModule.test_dataloader()
directly, without callingprepare_data()
orsetup()
. This can cause crashes or unexpected behaviour if users have implemented those methods.According to the Lightning docs, the correct way to run a test loop is to provide the full
datamodule
as an argument toTrainer.test()
.