This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Downloading checkpoints from AML if not found on disk #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-alvarez
previously approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a lot of things have been moved, so it is a bit difficult to review the real changes.
mebristo
reviewed
Dec 9, 2021
mebristo
reviewed
Dec 9, 2021
temp_folder = download_checkpoints_to_temp_folder() | ||
available_checkpoints = find_all_recovery_checkpoints(temp_folder) | ||
if available_checkpoints is not None: | ||
return extract_latest_checkpoint_and_epoch(available_checkpoints) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a potential scenario in which we are not currently running in AML, but we want to call download_checkpoints_to_temp_folder, i.e. for a previous Run?
mebristo
reviewed
Dec 9, 2021
Shruthi42
approved these changes
Dec 9, 2021
mebristo
approved these changes
Dec 9, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for an issue with low-priority preemption: checkpoint files are not available.
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.