Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Simplify setting callbacks in LightningContainers #617

Merged
merged 8 commits into from
Dec 13, 2021
Merged

Conversation

ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Dec 10, 2021

  • Callbacks presently need to be specified via trainer kwargs, which is cumbersome. Introduce a callbacks method.
  • Add a flag to control how often validation happens

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc enabled auto-merge (squash) December 10, 2021 12:43
@ant0nsc ant0nsc requested a review from mebristo December 11, 2021 12:09
@ant0nsc ant0nsc merged commit 7a36c59 into main Dec 13, 2021
@ant0nsc ant0nsc deleted the antonsc/flags branch December 13, 2021 13:26
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants